-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake install #3685
Cmake install #3685
Conversation
There is some |
@stweil, should we do the same for autotools, not install pdf.tff? |
That might be an incompatible change and require a new major version, even if the file was unused. |
@stweil |
Egor, your request conflicts with mine from #3673 - to focus on 5.x in 2022. |
Any guidelines for this? I had a look at https://semver.org/ and IMO such change has no effect on API and the new version would be backward compatible. |
I think that the C / C++ API is only one aspect of compatibility. Removing a file would break distributions which still have that file in their list of installed files. Users might have used that file for special applications. Note that it is not necessary to add |
This is aim to sync with autotools make install to satisfied requests like #3674
Question is if to install also pdf.tff - autotools install it, but it is not needed as there is pdf_ttf.h.
Relevant code is here:
tesseract/src/api/pdfrenderer.cpp
Lines 619 to 633 in 60fd2b4