Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with unreleased leptonica 1.83 #3921

Closed
wants to merge 1 commit into from

Conversation

p12tic
Copy link
Contributor

@p12tic p12tic commented Sep 20, 2022

leptonica moved most of their type definitions to internal headers. Long term usages of internal API should be removed, but for now simply include the internal header to allow tesseract to be built.

leptonica moved most of their type definitions to internal headers. Long
term usages of internal API should be removed, but for now simply
include the internal header to allow tesseract to be built.
@p12tic p12tic force-pushed the fix-build-new-leptonica branch from 8c6189c to 1eba029 Compare September 20, 2022 03:08
@p12tic
Copy link
Contributor Author

p12tic commented Sep 20, 2022

#3851 should probably merged instead of this PR (I reviewed that one), but if it looks too risky, then this PR is the simpliest possible fix.

@zdenop
Copy link
Contributor

zdenop commented Nov 24, 2022

close in favour of 3851

@zdenop zdenop closed this Nov 24, 2022
@amitdo
Copy link
Collaborator

amitdo commented Nov 25, 2022

#3851 should probably merged instead of this PR (I reviewed that one), but if it looks too risky, then this PR is the simpliest possible fix.

This comment is misleading. #3851 will not solve the issue that this PR is trying to solve. They are dealing with the same issue but in different files.

However, #3851 could be extended to solve the issue in additional file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants