Fix sign comparison wornings

tesseract-robotics · Jul 29, 2024 · d36545c · d36545c
1 parent c6b349c
commit d36545c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/mac.yml b/.github/workflows/mac.yml
@@ -95,8 +95,7 @@ jobs:
             -DOpenMP_C_INCLUDE_DIR=${{ matrix.config.homebrew_root }}/opt/libomp/include \
             -DOpenMP_CXX_LIB_NAMES=libomp -DOpenMP_CXX_FLAGS="-Xpreprocessor -fopenmp" \
             -DOpenMP_C_LIB_NAMES=libomp -DOpenMP_C_FLAGS="-Xpreprocessor -fopenmp" \
-            -DOpenMP_libomp_LIBRARY=${{ matrix.config.homebrew_root }}/opt/libomp/lib/libomp.dylib \
-            -DTESSERACT_WARNINGS_AS_ERRORS=OFF
+            -DOpenMP_libomp_LIBRARY=${{ matrix.config.homebrew_root }}/opt/libomp/lib/libomp.dylib
     - name: colcon test
       working-directory: ws
       run: |

diff --git a/tesseract_common/include/tesseract_common/yaml_utils.h b/tesseract_common/include/tesseract_common/yaml_utils.h
@@ -332,7 +332,8 @@ struct convert<Eigen::VectorXd>
   static Node encode(const Eigen::VectorXd& rhs)
   {
     Node node;
-    for (long i = 0; i < rhs.size(); ++i)
+    long l = static_cast<Eigen::Index>(rhs.size());
+    for (long i = 0; i < l; ++i)
       node.push_back(rhs(i));
 
     return node;
@@ -344,7 +345,8 @@ struct convert<Eigen::VectorXd>
       return false;
 
     rhs.resize(static_cast<Eigen::Index>(node.size()));
-    for (long i = 0; i < node.size(); ++i)
+    long l = static_cast<Eigen::Index>(node.size());
+    for (long i = 0; i < l; ++i)
       rhs(i) = node[i].as<double>();
 
     return true;

diff --git a/tesseract_environment/src/environment.cpp b/tesseract_environment/src/environment.cpp
@@ -1362,7 +1362,7 @@ bool Environment::Implementation::applyAddTrajectoryLinkCommand(const AddTraject
       return false;
     }
 
-    if (state.joint_names.size() != state.position.size())
+    if (static_cast<Eigen::Index>(state.joint_names.size()) != state.position.size())
     {
       CONSOLE_BRIDGE_logWarn("Tried to add trajectory link (%s) where joint names and position are different sizes.",
                              cmd->getLinkName().c_str());