Updated Dockerfile to support 24.04 #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marip8
force-pushed
the
update/dockerfile
branch
from
932481a to
3cc4799
Compare
|
The docker build for noble works, it just fails to build per the comment here |
|
Ready to be merged, unless you want to follow up on @johnwason 's comment tesseract-robotics/colcon-action#12 here as well. |
|
Lets try the --user option instead of having to the ros PPA. |
|
This can now be merged (because tesseract-robotics/colcon-action#14). |
Levi-Armstrong
approved these changes
Jun 23, 2024
Levi-Armstrong
merged commit 120c13d
into
tesseract-robotics:master
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes similar to #1006 to support Docker image build on 24.04