Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floating joint support #1060

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Nov 7, 2024

  • Update unit tests
    • Update existing tests
    • Add setState test with changing floating joint state values
  • Profile state solver

Master Branch:

Running ./tesseract_environment_kinematics
Run on (16 X 4600 MHz CPU s)
CPU Caches:
  L1 Data 48K (x8)
  L1 Instruction 32K (x8)
  L2 Unified 1280K (x8)
  L3 Unified 24576K (x1)
Load Average: 0.26, 1.58, 1.59
-----------------------------------------------------------------------------------------------------
Benchmark                                                           Time             CPU   Iterations
-----------------------------------------------------------------------------------------------------
BM_GET_STATE_JOINT_NAMES_JOINT_VALUES_SS/real_time               6.76 us         6.76 us       104520
BM_SET_AND_GET_STATE_JOINT_NAMES_JOINT_VALUES_SS/real_time       6.35 us         6.35 us       109127
BM_GET_JACOBIAN_JOINT_NAMES_JOINT_VALUES_SS/real_time            4.09 us         4.09 us       170754
BM_CALC_FWD_KIN_MANIP/real_time                                  8.60 us         8.60 us        80563
BM_GET_JACOBIAN_MANIP/real_time                                  3.23 us         3.23 us       217344

Post Changes:

Running ./tesseract_environment_kinematics
Run on (16 X 4600 MHz CPU s)
CPU Caches:
  L1 Data 48K (x8)
  L1 Instruction 32K (x8)
  L2 Unified 1280K (x8)
  L3 Unified 24576K (x1)
Load Average: 0.38, 0.68, 0.92
-----------------------------------------------------------------------------------------------------
Benchmark                                                           Time             CPU   Iterations
-----------------------------------------------------------------------------------------------------
BM_GET_STATE_JOINT_NAMES_JOINT_VALUES_SS/real_time               6.71 us         6.71 us       103161
BM_SET_AND_GET_STATE_JOINT_NAMES_JOINT_VALUES_SS/real_time       6.37 us         6.37 us       110148
BM_GET_JACOBIAN_JOINT_NAMES_JOINT_VALUES_SS/real_time            4.25 us         4.25 us       165280
BM_CALC_FWD_KIN_MANIP/real_time                                  8.14 us         8.14 us        85492
BM_GET_JACOBIAN_MANIP/real_time                                  3.35 us         3.35 us       209746

@Levi-Armstrong Levi-Armstrong force-pushed the feature/floating-joint-support branch 5 times, most recently from 1739619 to 536c75b Compare January 5, 2025 16:35
@Levi-Armstrong Levi-Armstrong marked this pull request as ready for review January 5, 2025 16:36
@Levi-Armstrong Levi-Armstrong force-pushed the feature/floating-joint-support branch 2 times, most recently from fcfc3a7 to 01cdc48 Compare January 5, 2025 16:59
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (c0162ef) to head (3dbc1a3).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   89.00%   88.75%   -0.26%     
==========================================
  Files         294      294              
  Lines       16460    16598     +138     
==========================================
+ Hits        14650    14731      +81     
- Misses       1810     1867      +57     

see 8 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong force-pushed the feature/floating-joint-support branch 2 times, most recently from dd8c088 to 7a2b83d Compare January 6, 2025 05:12
@Levi-Armstrong Levi-Armstrong requested a review from marip8 January 6, 2025 05:14
@Levi-Armstrong Levi-Armstrong force-pushed the feature/floating-joint-support branch from 7a2b83d to a701488 Compare January 6, 2025 22:02
@Levi-Armstrong Levi-Armstrong mentioned this pull request Jan 7, 2025
26 tasks
@Levi-Armstrong Levi-Armstrong force-pushed the feature/floating-joint-support branch from a701488 to 26f8826 Compare January 11, 2025 16:38
@Levi-Armstrong Levi-Armstrong force-pushed the feature/floating-joint-support branch from 26f8826 to 3dbc1a3 Compare January 11, 2025 16:38
@Levi-Armstrong Levi-Armstrong merged commit e84863f into tesseract-robotics:master Jan 11, 2025
13 of 15 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/floating-joint-support branch January 11, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants