Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path API functions to GeneralResourceLocator #1099

Conversation

johnwason
Copy link
Contributor

This PR adds API functions to GeneralResourceLocator to add paths to the locator using a constructor overload or the new addPath() function.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (ea05dde) to head (b7de279).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   89.06%   89.00%   -0.06%     
==========================================
  Files         294      294              
  Lines       16449    16460      +11     
==========================================
  Hits        14651    14651              
- Misses       1798     1809      +11     

see 4 files with indirect coverage changes

@Levi-Armstrong
Copy link
Contributor

It looks like you might need to squash everything and rebase before I can merge.

@johnwason johnwason force-pushed the general_resource_locator_api branch from 3f1fa69 to b7de279 Compare January 9, 2025 18:32
@Levi-Armstrong
Copy link
Contributor

@johnwason It looks like the mac CI is failing.

@johnwason
Copy link
Contributor Author

There is a new unrelated problem with bullet detection. It is something with the upstream vcpkg build. I will look at it in the next few days.

@Levi-Armstrong Levi-Armstrong merged commit 5b11d95 into tesseract-robotics:master Jan 9, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants