Add the ability to change KDL parameters from kinematics configuration #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
requested changes
Jan 31, 2023
tesseract_kinematics/kdl/include/tesseract_kinematics/kdl/kdl_utils.h
Outdated
Show resolved
Hide resolved
tesseract_kinematics/kdl/include/tesseract_kinematics/kdl/kdl_utils.h
Outdated
Show resolved
Hide resolved
tesseract_kinematics/kdl/include/tesseract_kinematics/kdl/kdl_utils.h
Outdated
Show resolved
Hide resolved
tesseract_kinematics/kdl/include/tesseract_kinematics/kdl/kdl_utils.h
Outdated
Show resolved
Hide resolved
tesseract_kinematics/kdl/include/tesseract_kinematics/kdl/kdl_inv_kin_chain_nr.h
Outdated
Show resolved
Hide resolved
Levi-Armstrong
requested changes
Feb 3, 2023
tesseract_kinematics/kdl/include/tesseract_kinematics/kdl/kdl_utils.h
Outdated
Show resolved
Hide resolved
|
I think the only thing left is to updated unit tests. I think if you give the config a default in the header it will fix most of them. Also if there are unit tests for parsing the yaml file those will need to be updated to account for the new parameters. It may be easiest to add parser code for each of the structs. |
- Add Eigen alignment - Trivialize assignment operators to avoid storing kdl_config (though I can do this if preferred) - Format
Levi-Armstrong
force-pushed
the
seanmc602/kdl-kinematics-config
branch
from
f51d9ca to
d7dda31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 90.18% 90.14% -0.05%
==========================================
Files 280 280
Lines 15800 15836 +36
==========================================
+ Hits 14250 14276 +26
- Misses 1550 1560 +10 |
Levi-Armstrong
merged commit 3124cd9
into
tesseract-robotics:master
9 of 13 checks passed
rjoomen
added a commit
to rjoomen/tesseract
that referenced
this pull request
Jun 3, 2024
…ics#843) - Some clang_tidy and typo fixes
Levi-Armstrong
pushed a commit
that referenced
this pull request
Jun 3, 2024
- Some clang_tidy and typo fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.