Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tesseract collision when calculate distance is disabled. #954

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong Levi-Armstrong force-pushed the fix/CollisionDistanceDisabled branch from f82fc32 to 80a937b Compare November 6, 2023 16:23
@Levi-Armstrong
Copy link
Contributor Author

@johnwason The latest release of yaml-cpp is broken, how do I update the windows CI to have it pull a specific version for this package?

@johnwason
Copy link
Contributor

@Levi-Armstrong here is the fix to the issue jbeder/yaml-cpp#1242

I think the solution is to check to see if yaml-cpp target already exists. This is probably going to be a problem in other places as well since the error made it into a release version. Here is an example for jsoncpp with the same issue (that still hasn't been fixed).

https://github.com/tesseract-robotics/trajopt/blob/2d965b931015fba9a83ca697e114e3c07ef7c25b/trajopt/CMakeLists.txt#L20

@johnwason
Copy link
Contributor

Oh I didn't notice that you created that pull request...

@Levi-Armstrong
Copy link
Contributor Author

@johnwason for now how can I set the version for yaml-cpp in your vcpkg action for this package?

@johnwason
Copy link
Contributor

You can use the revision option for vcpkg-action to select a git version for the vcpkg repository. I don't see an easy way to set the package version using the current vcpkg command. I can create a manifest in the future so we can select specific version of packages.

https://github.com/johnwason/vcpkg-action

@Levi-Armstrong Levi-Armstrong merged commit 4b93bfa into tesseract-robotics:master Nov 6, 2023
10 checks passed
@Levi-Armstrong Levi-Armstrong deleted the fix/CollisionDistanceDisabled branch November 6, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants