Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of Industrial CI #961

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@marip8
Copy link
Contributor

marip8 commented Nov 10, 2023

Have you thought about turning this into a custom Github action instead? Might be easier to apply to other tesseract repos in future as well

@Levi-Armstrong
Copy link
Contributor Author

Have you thought about turning this into a custom Github action instead? Might be easier to apply to other tesseract repos in future as well

Yea, that is not a bad idea. Have you ever created one?

@marip8
Copy link
Contributor

marip8 commented Nov 10, 2023

No I haven't, but I don't think it's too difficult. I think it can be as simple as a YAML file defining what steps should run as a part of the custom action and what the input variables can be. You can also have it call custom scripts in the action repo, etc.

@marip8
Copy link
Contributor

marip8 commented Nov 10, 2023

It might make sense to do make a similar custom Github action for building Docker images as well, since the Docker files for tesseract through tesseract_ros2 are not all that dissimilar from one another

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #961 (aa38bc3) into master (e4a0731) will decrease coverage by 0.87%.
The diff coverage is n/a.

❗ Current head aa38bc3 differs from pull request most recent head cd8a7b0. Consider uploading reports for the commit cd8a7b0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   91.78%   90.92%   -0.87%     
==========================================
  Files         243      280      +37     
  Lines       14918    15845     +927     
==========================================
+ Hits        13693    14407     +714     
- Misses       1225     1438     +213     

see 523 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong force-pushed the feat/DonotUseIndustrialCI branch 4 times, most recently from 82304c3 to f3f4cc7 Compare November 12, 2023 20:05
@Levi-Armstrong Levi-Armstrong force-pushed the feat/DonotUseIndustrialCI branch from f3f4cc7 to cd8a7b0 Compare November 12, 2023 20:21
@Levi-Armstrong Levi-Armstrong merged commit 9e65046 into tesseract-robotics:master Nov 12, 2023
4 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feat/DonotUseIndustrialCI branch November 12, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants