Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added application for performing convex decomposition #968

Merged

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Nov 24, 2023

Addition per commit message

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b4b9e1) 90.91% compared to head (e101cab) 90.91%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         280      280           
  Lines       15855    15855           
=======================================
  Hits        14414    14414           
  Misses       1441     1441           

@rjoomen
Copy link
Contributor

rjoomen commented Nov 27, 2023

Didn't test it, but LGTM. Essentially this is a variant of TestVHACD, you could consider to use the same parameter range checks (and possibly the same parameter format?).

@Levi-Armstrong
Copy link
Contributor

@marip8 Just need to fix clang-tidy issues and this can be merged.

@marip8
Copy link
Contributor Author

marip8 commented Dec 12, 2023

@marip8 Just need to fix clang-tidy issues and this can be merged.

Looks like all the clang-tidy issues come from VHACD.h. How do we ignore errors from this file?

@marip8 marip8 force-pushed the feature/convex-decomp-app branch from 740cd3b to be54e88 Compare December 12, 2023 00:19
@marip8 marip8 force-pushed the feature/convex-decomp-app branch from be54e88 to ab761cc Compare December 12, 2023 00:28
@rjoomen
Copy link
Contributor

rjoomen commented Dec 12, 2023

Looks like all the clang-tidy issues come from VHACD.h. How do we ignore errors from this file?

Seems TESSERACT_COMMON_IGNORE_WARNINGS_PUSH does not work for newer clang-tidy. You could add // NOLINTBEGIN just after TESSERACT_COMMON_IGNORE_WARNINGS_PUSH and and // NOLINTEND just before TESSERACT_COMMON_IGNORE_WARNINGS_POP. That solves it for me.

@rjoomen
Copy link
Contributor

rjoomen commented Dec 13, 2023

It seems adding NOLINTBEGIN and END to the macros does not work. I suggested adding them to VHACD.h, does that work?

@Levi-Armstrong Levi-Armstrong merged commit 23be16f into tesseract-robotics:master Jan 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants