Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffective frame.Identity() call #985

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Jan 24, 2024

Closes #984

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5155e20) 90.91% compared to head (6e501f3) 90.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   90.91%   90.91%   -0.01%     
==========================================
  Files         280      280              
  Lines       15855    15854       -1     
==========================================
- Hits        14415    14413       -2     
- Misses       1440     1441       +1     

see 2 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong merged commit f0e5732 into master Jan 25, 2024
13 checks passed
@rjoomen rjoomen deleted the rjoomen-patch-1 branch January 25, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frame is not set to identity
2 participants