Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.yml to allow workflow_dispatch #443

Closed
wants to merge 1 commit into from

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@marip8
Copy link
Contributor

marip8 commented Feb 23, 2024

If you intend for this change to be able to push new docker images to the registry on command, then I think you will also have to update the PUSH_DOCKER_IMAGE variable. Right now it will only push when the reference branch is master (which may or may not be the case when you manually trigger this pipeline) or on release events. I looked into it briefly at one point and I wasn't able to quickly track down an event name associated with manual triggers

@Levi-Armstrong
Copy link
Contributor Author

@marip8 It looks like the docker file uses the dependencies.repos for both master and release docker creation. How can we update this so when building the master image it using the dependencies_unstable.repos?

@Levi-Armstrong
Copy link
Contributor Author

@marip8 or @marrts Do you either have time to look into how best to update the docker build to the unstable docker build pulls trajopt master?

@marip8
Copy link
Contributor

marip8 commented Feb 28, 2024

I can look into it

@Levi-Armstrong
Copy link
Contributor Author

This is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants