New ompl profile interface #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
feature/new-ompl-profile
branch
2 times, most recently
from
11c17b1 to
29ba1ed
Compare
Levi-Armstrong
changed the title
|
@marip8 Do you have time to take a look and provide feedback? |
Levi-Armstrong
force-pushed
the
feature/new-ompl-profile
branch
2 times, most recently
from
612b40c to
08b94ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 78.91% 78.41% -0.50%
==========================================
Files 253 252 -1
Lines 14548 13734 -814
==========================================
- Hits 11480 10770 -710
+ Misses 3068 2964 -104 |
Levi-Armstrong
force-pushed
the
feature/new-ompl-profile
branch
5 times, most recently
from
d5ec326 to
a20fc18
Compare
This was referenced Dec 18, 2024
Levi-Armstrong
force-pushed
the
feature/new-ompl-profile
branch
3 times, most recently
from
8557822 to
b343016
Compare
Levi-Armstrong
force-pushed
the
feature/new-ompl-profile
branch
from
b343016 to
29b8937
Compare
Levi-Armstrong
merged commit e00ae6f
into
tesseract-robotics:master
12 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to simplify the profiles interface and allow moving them to be loaded via plugin. As going through this I was able to main all of the same functionality along with the customization for the default profile. The initial thought was that we could go to a single profile for each planner but now I do not think that will be possible. We may be able to combine the solver and composite profile but we will have to have a distinction between the plan profile and composite profile. I do not currently see any way around this but open to ideas.