Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching up to tesseract_ros #34

Open
4 of 7 tasks
marrts opened this issue Nov 9, 2022 · 8 comments
Open
4 of 7 tasks

Catching up to tesseract_ros #34

marrts opened this issue Nov 9, 2022 · 8 comments

Comments

@marrts
Copy link
Contributor

marrts commented Nov 9, 2022

With #33 most of the functionality is there, but there are a few differences or changes that need to be made to fully catch up.

  • Topic fields in the workbench don't actually look up ROS topics, they just take string inputs
  • Can't run waitForInput() when running from a launch because of how ROS 2 interfaces with the terminal, an alternative should be proposed, or we can just choose to drop this
  • Manipulation widget does not work in the workbench, for some reason we are unable to move around the manipulation objects, but we can change numbers to move the robot to different positions, it is just less efficient
  • tesseract_rviz causing a build issue when rebuilding
  • If you want to load the URDF/SRDF into RVIZ as parameters you need to launch RVIZ node with those parameters declared, again this is more of a difference between ROS and ROS 2 than a tesseract thing
  • Currently tesseract_rviz uses boost::shared_ptrs everywhere because that's what ROS 1 rviz did, but ROS 2 uses std::shared_ptrs so we should probably update to match
  • The planning server itself isn't yet ported
@marrts marrts mentioned this issue Nov 9, 2022
@marrts
Copy link
Contributor Author

marrts commented Nov 9, 2022

@smith-doug did we resolve the tesseract_rviz building issue, I can't remember?

@smith-doug
Copy link
Contributor

@rjoomen rjoomen mentioned this issue Jan 18, 2023
@rjoomen
Copy link
Contributor

rjoomen commented Feb 20, 2023

I made a PR to the repo of @marrts.

This includes fixes for the first (ROS topics) and the before-last (boost) points in the list above.

@Levi-Armstrong
Copy link
Contributor

@marrts can this be closed?

@rjoomen
Copy link
Contributor

rjoomen commented Mar 1, 2023

No, some issues are still open, I think. I suggest to check the points that are done though.

@marrts
Copy link
Contributor Author

marrts commented Mar 2, 2023

Checked off the issues resolved by @rjoomen

@rjoomen
Copy link
Contributor

rjoomen commented Oct 18, 2023

@Levi-Armstrong I think the point about the manipulation widget can be closed, as it seems to work the same as tesseract_ros1 now, right? Then we could close the entire issue, as the other two points can't be fixed.

@Levi-Armstrong
Copy link
Contributor

Sound good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants