tsp configs for sphere #3349
Closed
tsp configs for sphere #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4 30 preview (Azure#28713) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-04-30-preview Updated the API version from stable/2024-04-01 to preview/2024-04-30-preview. * Added tag for 2024-04-30-preview in readme file * update specs examples and readme * fix pretty checks * fix all examples pretty checks * fix pretty checks for nested * add example reference --------- Co-authored-by: madhura <[email protected]>
* Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-04-30-preview Updated the API version from stable/2024-04-01 to preview/2024-04-30-preview. * Added tag for 2024-04-30-preview in readme file * fix pretty checks * fix readme --------- Co-authored-by: madhura <[email protected]>
…zure#28969) * set to required=true and resolution defaults to medium (See TASK 27941576). * addressing feedback
* changes for CSharp
…sion 2023-11-01-preview (Azure#28842) * Fixed operationIds in examples * Removed @Autorest.example decorator. * Added examples descriptions
* change the api version of tags * fix avacado error
Co-authored-by: Yuchao Yan <[email protected]>
…point (Azure#29049) * fix: Update `endpoint` type to `url` from `str` This resolves an issue where the python codegen would try to escape the `://` characters from the url's scheme. * fix: Point the typespec to the correct base endpoint * chore: Update azure-ai-assets.json
* Remove multipart dedicated model * Remove locale in links * Add description for search over entire pd * Rename enum * Modify java config
* Add query property for Salesforce V2 * Change deprecating description * Add type description --------- Co-authored-by: madhura <[email protected]>
* Swagger changes for ServiceNowV2 expression app model. * Changes * updates * updates * Update Pipeline.json * Update sdk-suppressions.yaml * add azure-sdk-for-go suppression * Update sdk-suppressions.yaml * Update sdk-suppressions.yaml --------- Co-authored-by: ms-kanikagupta <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
…cluster (Azure#27733) * Generate new Service for cosmosdbmongoclusters * Add cosmosdbmongoclusters service for Microsoft.DocumentDB RP. Includes TypeSpec definitions, examples, scenario tests and generated Swagger API files * First phase of renaming to mongocluster in files only * Rename example files, cleanup additional name changes * Rename folder * removed the old examples * Remove plural MongoClusters * Move typespec to DocumentDB.MongoCluster.Management * move mongoclusters->mongocluster for the service folder * Fix plural resource type * Final renames * Add private link and private endpoint resources * Rename * Fix examples * Fix examples * Add Accepted/202 pattern for firewall and PEC. Add correct async headers to examples. * Fix LROHeaders and example names * Remove Accepted 202 support for firewall/PEC create - to be added in future api release * Fix new line * Fixes * Auto-correct * Fix scenario tests * Add Accepted/202 pattern for firewall and PEC. Add correct async headers to examples. * Fix LROHeaders and example names * Adding accepted response handling * Add results of last compile * Fix formatting --------- Co-authored-by: madhura <[email protected]>
…sing properties (Azure#28280) * Add CMK related properties * Fix lintdiff errors * Fix lintdiff error * Use common type for user assigned identities * Add description for primary key uri * Update UserAssignedIdentities definition from v3 to v5 * Add & update examples * Fix lintdiff error --------- Co-authored-by: madhura <[email protected]>
* Adds base for updating Microsoft.CognitiveServices from version preview/2023-10-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Cognitive Services 2024-04-01-preview * Add NSP APIs * address some error * address lintdiff error * Add list for defender * fix nsp ModelValidation * Add Mode Capacities Apis * fix example * Added properties for models api * Update models APIs * fix a name * Removed getModel * Change an example name * Fix example name * Update NSP APIs * update PutRaiPolicy example * using proxy resource type * Fix example * Remove models API from 04-01-preview * Remove sibling values alongside $ref * Address ModelValidation check * Address comments * fix breaking change * address NSP comments * fix nsp example * fix NSP * fix an example * fix sdk-go * Fix modelCapacities APIs * removed $ --------- Co-authored-by: madhura <[email protected]>
…able (Azure#29013) Co-authored-by: Akshit Goyal <[email protected]> Co-authored-by: Roopesh Manda <[email protected]>
* Adds base for updating Microsoft.Chaos from version preview/2023-10-27-preview to version 2024-03-22-preview * Updates readme * Updates API version in new specs and examples * merge in 2024-01-01 stable branch additions * Add PublicNetworkAccess Field under privateAccesses resource (Azure#28110) * Add new field for privateAccess * Fix reference * Fix PublicNetworkAccess definition * Fix PrettierCheck * Fix enum name * Rename enum property * Test my push permission * Adds base for updating Microsoft.Chaos from version preview/2023-10-27-preview to version 2024-03-22-preview * Updates readme * Updates API version in new specs and examples * merge in 2024-01-01 stable branch additions * Add PublicNetworkAccess Field under privateAccesses resource (Azure#28110) * Add new field for privateAccess * Fix reference * Fix PublicNetworkAccess definition * Fix PrettierCheck * Fix enum name * Rename enum property * Convert two operations to be async (Azure#28350) * Convert two operations to be async * Fix examples * Resolve comments * Change delete async operation status code * Added Patch Tags Endpoint to Private Link (Azure#28296) * Added UpdatePrivateAccessTags endpoint * Addressing points for the PR review, it was about rename the new private link endpoint to PrivateAccesses_Patch, and changned the return code from 200 to 202 * Update the Private Access tags payload --------- Co-authored-by: Adi Hazeem <[email protected]> * update readme * Resolved conflict * Resolved conflict * Resolved conflict * Fix linting error for PUT and DELETE (Azure#28417) * Fix check error * move readonly flag * Added 200 response to PrivateAccess Tags Patch Endpoint (Azure#28465) * Added 200 response to PrivateAccess Tags example --------- Co-authored-by: Adi Hazeem <[email protected]> * add missing LRO header to open api spec * attempted model validation fix * fixed prop spelling mistake * prettier * remove unused example file * move common type definition to pick up from latest official typing file * move common type definition to pick up from latest official typing file (Azure#28870) Co-authored-by: James Duan <[email protected]> * fix id format in sample file * address review comments from Tim (Azure#28991) Co-authored-by: James Duan <[email protected]> --------- Co-authored-by: James Duan <[email protected]> Co-authored-by: RayY-96 <[email protected]> Co-authored-by: Adi Hazeem <[email protected]> Co-authored-by: Adi Hazeem <[email protected]> Co-authored-by: Brent Rusinow (from Dev Box) <[email protected]>
* Adds base for updating Microsoft.DevCenter from version preview/2023-10-01-preview to version 2024-05-01-preview * Updates readme * Updates API version in new specs and examples * add new changes for 2024-05-01-preview * run prettier and fix * Add directive to supress HostParametersValidation lintdiff errors * fix ntegerTypeMustHaveFormat lintdiff error * add suppression for OperationIdNounVerb * Add new API changes in TypeSpec * Generate the swagger from TypeSpec * fix tag name * Fix package tag for real * Add missing examples to TypeSpec folder * Recompile * Few more fixes * Some more fixes * Fix validateCustomizationTasksAction route to be LRO * Fix issues with examples. Remove a couple of old ones. Add two missing ones * Run linter * Validate Customization group route changes * Fix another example with accept header/param * Update visbility since the name can be used in post actions * Needs to be CREATE visibility per documentation * Rename timeout to timeoutInSeconds * Merge latest with main, fix package-lock issue, run npx tsv devcenter * Update comment as per PR suggestions * Change route * Remove regionality from supporting documents link, use Azure.Core.Foundations.Error object instead of our own * Configure param with query parameter traits * Add a missing space * Fix header, should actually be in response * Fix warnings due to missing doc descriptions * Run linter * use dayton's wording for tasks include parameter * Remove unncessary statusCode in response object * Remove unnecessary @action decorator since the action name is already included in the route --------- Co-authored-by: Sneha Nagendra <[email protected]> Co-authored-by: Arber Hila <[email protected]> Co-authored-by: Arber Hila <[email protected]>
* Adds base for updating Microsoft.DesktopVirtualization from version stable/2023-09-05 to version 2024-04-03 * Updates readme * Updates API version in new specs and examples * Added AppAttachPackage to latest stable * BREAKING CHANGE: added pattern to name parameters for objects. * added from in readme * Added nullable true to properties to match actual service implementation * Replaced all v* instances to v5 * Updated examples * Changed app attach to be TrackedResource * anyOf * Resource all of and tags explicitly defined * Removed force delete from AppAttach * Few code review fixes * Rest of code review fixes * Create sdk-suppressions.yaml * Update sdk-suppressions.yaml --------- Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: madhura <[email protected]>
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Swagger Validation Report
|
| Rule | Message |
|---|
️❌Breaking Change(Cross-Version): 223 Errors, 407 Warnings failed [Detail]
Only 0 items are rendered, please refer to log for more details.
The following breaking changes are detected by comparison with the latest stable version:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
The following breaking changes are detected by comparison with latest preview version:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌LintDiff: 3 Errors, 86 Warnings failed [Detail]
Only 0 items are rendered, please refer to log for more details.
[must fix]The following errors/warnings are introduced by current PR:
Only -1 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|
The following errors/warnings exist before current PR submission:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️❌TypeSpecAPIView: 0 Errors, 1 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌Avocado: 6 Errors, 3 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛PR Summary pending [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
This was referenced May 14, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.