Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNR brInfo_cross_ver_brch branch #3376

Closed
wants to merge 1 commit into from
Closed

DNR brInfo_cross_ver_brch branch #3376

wants to merge 1 commit into from

Conversation

konrad-jamrozik
Copy link

DO NOT REVIEW! This is a test PR created by kojamroz from branch brInfo_cross_ver_brch.

Information about this PR extracted from BRANCH_INFO.md

This branch was created by kojamroz on 6/26/2024

This branch is expected to trigger cross-version breaking change report between stable version.
In addition, the TypeSpec requirement check should not trigger.

It differs from main as follows:

  1. It introduces a new directory:

specification/alertsmanagement/resource-manager/Microsoft.AlertsManagement/stable/2024-05-01

which is a copy of;
specification/alertsmanagement/resource-manager/Microsoft.AlertsManagement/stable/2023-03-01

  1. In the new directory the following file:
    specification/alertsmanagement/resource-manager/Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json

Differs from its original. It has operationID:

"operationId": "CROSS_VER_BREAKING_CHANGE_TEST_PrometheusRuleGroups_ListBySubscription",

instead of:

"operationId": "PrometheusRuleGroups_ListBySubscription",

In addition, all files got their "version" updated to be "2024-05-01".

  1. The README:

specification/alertsmanagement/resource-manager/readme.md

The default tag has been changed to package-2024-05 and following entry was added:

Tag: package-2024-05

These settings apply only when --tag=package-2024-05 is specified on the command line.

input-file:
  - Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json
  - Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json
  - Microsoft.AlertsManagement/preview/2019-05-05-preview/SmartGroups.json
  - Microsoft.AlertsManagement/preview/2023-08-01-preview/AlertRuleRecommendations.json
  - Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json

@konrad-jamrozik konrad-jamrozik self-assigned this Jun 26, 2024
@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jun 26, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review

@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jun 26, 2024 •
edited
Loading

Swagger Generation Artifacts

️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Failed in generating from c682ea396f5b1dfb5bc086f2789a19accdbd94d7. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		Warning: azure-sdk-for-net-track2 cannot be found in specification/agrifood/resource-manager/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[DotNet-Sdk-Automation]      | Failed to generate sdk. exit code: False
  • ❌Azure.ResourceManager.AlertsManagement [Preview SDK Changes] 
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from c682ea396f5b1dfb5bc086f2789a19accdbd94d7. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-agrifood [Preview SDK Changes]
  • ️✔️azure-mgmt-alertsmanagement [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from c682ea396f5b1dfb5bc086f2789a19accdbd94d7. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/agrifood/armagrifood [Preview SDK Changes]
  • ️✔️sdk/resourcemanager/alertsmanagement/armalertsmanagement [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Code Generator Failed in generating from c682ea396f5b1dfb5bc086f2789a19accdbd94d7. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
warn		Warning: azure-resource-manager-schemas cannot be found in specification/agrifood/resource-manager/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️⚠️ azure-powershell warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from c682ea396f5b1dfb5bc086f2789a19accdbd94d7. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.agrifood.DefaultTag [Preview SDK Changes]
  • ⚠️Az.alertsmanagement.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jun 26, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/agrifood/armagrifood https://apiviewstagingtest.com/Assemblies/Review/0948dfb1fb1d47be859656e82e1b43e4?revisionId=d0f1f10165a04f75a42401e5135d3183
Go sdk/resourcemanager/alertsmanagement/armalertsmanagement https://apiviewstagingtest.com/Assemblies/Review/96ab4957edf14700bae2bd57dbb3f226?revisionId=0b92df93f59c4e2d8f5041e713dd670b
.Net Azure.ResourceManager.AlertsManagement https://apiviewstagingtest.com/Assemblies/Review/7f11609d0ac145c197ff0fa01bd85216?revisionId=1cdc2c122ce44dc0a30baed7a313c025
Swagger Microsoft.AlertsManagement https://apiviewstagingtest.com/Assemblies/Review/112510d47e054569b515b92ac01535e6?revisionId=5b1f59e562c94d54bbcc487b19bf8e64

@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jun 26, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️❌Breaking Change(Cross-Version): 1 Errors, 12 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
PrometheusRuleGroups.json 2024-05-01(aafce1e) 2023-03-01(main)
PrometheusRuleGroups.json 2024-05-01(aafce1e) 2021-07-22-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
❌ 1008 - ModifiedOperationId The operation id has been changed from 'PrometheusRuleGroups_ListBySubscription' to 'CROSS_VER_BREAKING_CHANGE_TEST_PrometheusRuleGroups_ListBySubscription'. This will impact generated code.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L31:7
Old: Microsoft.AlertsManagement/stable/2023-03-01/PrometheusRuleGroups.json#L31:7


The following breaking changes are detected by comparison with latest preview version:

Rule Message
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrometheusRuleGroupResourcePatch' removed or renamed?
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L301:3
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L298:3
⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'PrometheusRuleGroups_ListBySubscription' to 'CROSS_VER_BREAKING_CHANGE_TEST_PrometheusRuleGroups_ListBySubscription'. This will impact generated code.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L31:7
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L31:7
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L446:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L458:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L233:13
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L230:13
⚠️ 1023 - TypeFormatChanged The new version has a different format 'duration' than the previous one ''.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L384:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L344:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'duration' than the previous one ''.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L434:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L440:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'duration' than the previous one ''.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L489:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L479:9
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L118:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L118:9
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L158:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L158:9
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L216:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L213:9
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L265:9
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L262:9
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L498:5
Old: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L488:5
️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
Compared specs (v2.2.2) new version base version
package-2024-05 package-2024-05(aafce1e) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ OperationIdSingleUnderscore Only 1 underscore is permitted in the operation id, following Noun_Verb conventions
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L36


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L48
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L90
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L422
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L439
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L472
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L39
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L42
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L55
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L78
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L81
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L84
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L97
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L120
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L123
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L129
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L142
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L160
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L163
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L169
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L197
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L218
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L221
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L227
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L249
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L267
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L270
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L276
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L289
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L306
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/stable/2024-05-01/PrometheusRuleGroups.json#L335
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/alertsmanagement/resource-manager/readme.md
tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2024-05
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@konrad-jamrozik
Copy link
Author

PR to test:

@konrad-jamrozik
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 26, 2024
Closed
Closed
@konrad-jamrozik
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@konrad-jamrozik
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@konrad-jamrozik
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@konrad-jamrozik
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@konrad-jamrozik
Copy link
Author

/azp run

@konrad-jamrozik konrad-jamrozik changed the base branch from main to users/kojamroz/brInfo_breaking_change July 8, 2024 22:34
@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@konrad-jamrozik konrad-jamrozik changed the base branch from users/kojamroz/brInfo_breaking_change to main July 8, 2024 22:34
@konrad-jamrozik konrad-jamrozik force-pushed the users/kojamroz/brInfo_cross_ver_brch branch from 545b230 to aafce1e Compare July 8, 2024 22:35
@konrad-jamrozik konrad-jamrozik force-pushed the users/kojamroz/brInfo_cross_ver_brch branch from aafce1e to 2bf2180 Compare July 8, 2024 22:39
@konrad-jamrozik konrad-jamrozik changed the base branch from main to users/kojamroz/brInfo_breaking_change July 8, 2024 22:40
@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

This was referenced Jul 8, 2024
Closed
Closed
Closed
This was referenced Jul 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyyc msyyc Awaiting requested review from msyyc

@qiaozha qiaozha Awaiting requested review from qiaozha

@weshaggard weshaggard Awaiting requested review from weshaggard

@mikeharder mikeharder Awaiting requested review from mikeharder

@benbp benbp Awaiting requested review from benbp

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Approved-LintDiff Approved-SdkBreakingChange-Go Approved-SdkBreakingChange-Go-V2 ARMReview BreakingChange-Approved-Benign BreakingChangeReviewRequired new-api-version resource-manager WaitForARMFeedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konrad-jamrozik @AzureRestAPISpecReview