Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNR brInfo_breaking_change branch #3402

Closed
wants to merge 1 commit into from

Conversation

konrad-jamrozik
Copy link

DO NOT REVIEW! This is a test PR created by kojamroz from branch brInfo_breaking_change.

Information about this PR extracted from BRANCH_INFO.md

This branch was created by kojamroz on 4/9/2024.
It differs from main as follows:

It modifies

specification/agrifood/resource-manager/Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json

by introducing a breaking change:

"operationId": "Extensions_Create",

changed to

"operationId": "Extensions_Create2",

@konrad-jamrozik konrad-jamrozik self-assigned this Jul 9, 2024
Copy link

openapi-pipeline-app-test bot commented Jul 9, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either introduce a new API version with these changes instead of modifying an existing API version To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Requirement (resource-manager) has failed. TypeSpec usage is required for all new (aka "greenfield") services. The automation detected this pull request adds at least one new service that is violating this requirement. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp

Copy link

openapi-pipeline-app-test bot commented Jul 9, 2024

Swagger Generation Artifacts

️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from ddc4eb612308f4b15d2b35cd60e763df2cfbf673. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-agrifood [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from ddc4eb612308f4b15d2b35cd60e763df2cfbf673. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/agrifood/armagrifood [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from ddc4eb612308f4b15d2b35cd60e763df2cfbf673. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-agrifood [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from ddc4eb612308f4b15d2b35cd60e763df2cfbf673. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-agrifood [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-powershell warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from ddc4eb612308f4b15d2b35cd60e763df2cfbf673. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.agrifood.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Jul 9, 2024

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
agfood.json 2020-05-12-preview(162015a) 2020-05-12-preview(main)
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'Extensions_Create' to 'Extensions_Create2'. This will impact generated code.
New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7
Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2020-05-12-preview package-2020-05-12-preview(162015a) package-2020-05-12-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L56
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L102
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L148
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L195
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L466
ParametersOrder The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L510
ParametersOrder The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L571
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L596
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L601
ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1167
⚠️ PreviewVersionOverOneYear The API version:2020-05-12-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L6
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L30
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L33
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L73
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L79
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L92
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L119
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L122
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L125
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L138
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L165
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L168
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L171
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L184
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@konrad-jamrozik
Copy link
Author

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@konrad-jamrozik
Copy link
Author

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants