chore: add caching to Linux docker run #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @stevenh what are the motivation for this PR? Do you think it makes a real difference with the current state of the release process? IIUC this will happen at build time of Ryuk, which is done just once per release. I see the benefits of building a Docker image faster, but want to check with you the implications/importance of this update. Thanks! |
|
For the release process no benefit. For the developer working on this it was much quicker iteration time, which was the motivation. |
stevenh
force-pushed
the
chore/mount-caching
branch
from
9c2cf45 to
e54e2a2
Compare
Add cache mount directives to Linux docker container so that reruns are much quicker.
stevenh
force-pushed
the
chore/mount-caching
branch
from
e54e2a2 to
c070a46
Compare
kiview
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache mount directives to Linux docker container so that reruns are much quicker.