Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-actions): depend on the right workflow #138

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mdelapenya
Copy link
Member

This PR is using the right job when releasing the Ryuk project.

It was possibly wrong after #120

@mdelapenya mdelapenya requested a review from a team as a code owner July 15, 2024 16:11
@mdelapenya mdelapenya added the github_actions Pull requests that update GitHub Actions code label Jul 15, 2024
@mdelapenya mdelapenya self-assigned this Jul 15, 2024
@mdelapenya mdelapenya requested a review from kiview July 15, 2024 16:11
@mdelapenya
Copy link
Member Author

@gesellix I think we screwed it up in #120. Could you take a look 🙏 I'm planning a new release and it failed https://github.com/testcontainers/moby-ryuk/actions/runs/9942721870

Thank you in advance!

Copy link
Contributor

@gesellix gesellix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also think that's a leftover/copy&paste-error from the normal build workflow. The fix looks correct to me. 👍

@mdelapenya mdelapenya merged commit 2035aab into testcontainers:main Jul 15, 2024
9 checks passed
@mdelapenya mdelapenya deleted the fix-release-process branch July 15, 2024 16:19
gesellix added a commit to gesellix/testcontainers-helloworld that referenced this pull request Jul 15, 2024
gesellix added a commit to gesellix/testcontainers-helloworld that referenced this pull request Jul 15, 2024
@gesellix
Copy link
Contributor

@mdelapenya this one is also up-to-date now, including the fixed workflow reference: testcontainers/helloworld#5

mdelapenya pushed a commit to testcontainers/helloworld that referenced this pull request Aug 7, 2024
* Build multi-arch image including Windows

* Sync workflows from testcontainers/moby-ryuk

* Fix workflow reference

See testcontainers/moby-ryuk#138

* Sync with the workflows from moby-ryuk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants