fix: use Started instead of listening #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid breaking existing clients of Ryuk, using a custom Ryuk version with older testcontainers versions.
eddumelendez
previously approved these changes
Oct 9, 2024
stevenh
requested changes
Oct 9, 2024
stevenh
requested changes
Oct 10, 2024
stevenh
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses
Startedinstead oflisteningin the log to define that Ryuk properly initialised.Why is this important?
To avoid breaking existing clients of Ryuk, which could be updating the Ryuk version in the properties file
Related issues
Follow-up questions
I wonder what are the different use cases to have a different ryuk version at the properties level and not use the one provided by the library.
I acknowledge that we introduced a breaking change when we updated the log format to a more structured one, which we are fixing in this PR, but if the user puts a wrong version in the properties, like a very outdated ryuk version, what can we do in that case?