Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gradle): jarFileTest setup #9582

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

patrick-dedication
Copy link
Contributor

@patrick-dedication patrick-dedication commented Dec 2, 2024

The commit descriptions should be self explanatory.
For the JvmTestSuitePlugin docs see here.

This was simply a call to project.file which has no effect on this task.
The inputs prefix was not added when this was added with commit:
b5331f4
When using gradle types as inputs task dependencies are tracked automatically.
task.outputs returns a gradle type while singleFile returns a plain java File.
This is the new and recommended way and also how it is done for the
unit-test setup internally in gradle by now.
@patrick-dedication patrick-dedication requested a review from a team as a code owner December 2, 2024 06:24
@eddumelendez
Copy link
Member

Hi, thanks for the PR. The plugin is still incubating.

@patrick-dedication
Copy link
Contributor Author

Yeah sure, but there is tons of people already relying on it, also gradle interally, so I bet any changes will be minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants