Port BigQueryContainer from testcontainers-java #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution. There is an existing bug related to the streaming API, see testcontainers/testcontainers-java#7787. I would prefer to hold on until the recommendation is applied in the bigquery image rather than having the issue in both implementation. |
|
hi @jvaesteves we've restructured the repo, can you please rebase or create the change again with the new structure? |
|
attempted a rebase here - main...alexanderankin:testcontainers-python:bq-rb |
|
and adjusted linting here - https://github.com/alexanderankin/testcontainers-python/pull/new/bq-rb-adjust |
alexanderankin
added
the
community-feat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BigQueryContainer based on BigQueryEmulatorContainer.java