Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mosquitto): module name #740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

crankcase
Copy link

@crankcase crankcase commented Nov 23, 2024

Mosquitto module used wrong name mqtt, but mqtt its name of protocol and also other modules use naming convention <module name>.<ModuleName>Container

There also wrong name in community-module-registry documentation https://github.com/testcontainers/community-module-registry/blob/main/modules/mosquitto/index.md?plain=1#L16

I have prepared separate RP testcontainers/community-module-registry#97

@crankcase crankcase changed the title Fix mosquitto module name fix(mosquitto): module name Nov 23, 2024
@alexanderankin
Copy link
Member

I'm not sure we want to do this as it would be a breaking change. maybe a v5 item? #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants