perf: avoid spawning log producer without consumers (#689)

testcontainers · Jul 7, 2024 · 3263313 · 3263313
1 parent f79ed70
commit 3263313
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/testcontainers/src/core/containers/async_container.rs b/testcontainers/src/core/containers/async_container.rs
@@ -65,23 +65,27 @@ where
             dropped: false,
         };
 
-        let mut logs = container.docker_client.logs(&container.id, true);
-        let container_id = container.id.clone();
-        tokio::spawn(async move {
-            while let Some(result) = logs.next().await {
-                match result {
-                    Ok(record) => {
-                        for consumer in &log_consumers {
-                            consumer.accept(&record).await;
-                            tokio::task::yield_now().await;
+        if !log_consumers.is_empty() {
+            let mut logs = container.docker_client.logs(&container.id, true);
+            let container_id = container.id.clone();
+            tokio::spawn(async move {
+                while let Some(result) = logs.next().await {
+                    match result {
+                        Ok(record) => {
+                            for consumer in &log_consumers {
+                                consumer.accept(&record).await;
+                                tokio::task::yield_now().await;
+                            }
+                        }
+                        Err(err) => {
+                            log::warn!(
+                                "Failed to read log frame for container {container_id}: {err}",
+                            );
                         }
-                    }
-                    Err(err) => {
-                        log::warn!("Failed to read log frame for container {container_id}: {err}",);
                     }
                 }
-            }
-        });
+            });
+        }
 
         let ready_conditions = container.image().ready_conditions();
         container.block_until_ready(ready_conditions).await?;