feat: add container hostname support #848
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker container create command supports the --hostname parameter [1]. This is also supported through the Bollard library as part of the the ContainerCreateBody struct [2]. This commit adds the option to configure this parameter through the ImageExt trait. This was previously proposed for an older version of testcontainers-rs [3], however it was rejected. The usefulness of this feature is to allow programs inside the container to report back a hostname that makes sense in a test environment. For instance, ClickHouse has the hostName function [4] which will report this configured value. By default Docker assigns the Docker container ID, which in an integration testing context isn't that useful. [1]: https://docs.docker.com/reference/cli/docker/container/create/ [2]: https://docs.rs/bollard/latest/bollard/secret/struct.ContainerCreateBody.html [3]: testcontainers#539 [4]: https://clickhouse.com/docs/sql-reference/functions/other-functions#hostname Signed-off-by: Kevin Languasco <[email protected]>
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DDtKey
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker container create command supports the --hostname parameter (1). This is also supported through the Bollard library as part of the the ContainerCreateBody struct (2). This commit adds the option to configure this parameter through the ImageExt trait.
This was previously proposed for an older version of testcontainers-rs (3), however it was rejected.
The usefulness of this feature is to allow programs inside the container to report back a hostname that makes sense in a test environment. For instance, ClickHouse has the hostName function (4) which will report this configured value. By default Docker assigns the Docker container ID, which in an integration testing context isn't that useful.