Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create github-mgmt stewards team #36

Merged
merged 7 commits into from
Sep 12, 2022
Merged

create github-mgmt stewards team #36

merged 7 commits into from
Sep 12, 2022

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Sep 2, 2022

This PR creates a new team called github-mgmt stewards and grants it write access to github-mgmt repository.

The general idea is to build up github-mgmt stewards team with users who are:

  • familiar with GitHub Management
  • trusted within the org
  • want/need to be able to triage/merge PRs

github-mgmt stewards should be the only team with write access to github-mgmt repository, eventually

Here's my proposal for initial members:

Here is a short intro doc to GitHub Management Stewards I prepared - https://github.com/testground/github-mgmt/blob/3eedb7927d567f2ddb713569561ce2cb5ecafbfe/docs/STEWARDSHIP.md This is intended only as a v0 and should definitely be updated according to how the team in this org intends to organise their work.

Similar change was introduced recently in the ipfs org. See ipfs/github-mgmt#37 for more details.

TODO
  • get approval for initial github-mgmt stewards team members from Steve
  • prepare 1 page document on what is expected of a github-mgmt steward
  • mention proposed members once the PR is ready for review

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

testground

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # github_repository_file.this["github-mgmt/CODEOWNERS"] will be updated in-place
  ~ resource "github_repository_file" "this" {
      ~ content             = <<-EOT
          - *       @galargh
          + # The ipdx team is responsible for GitHub Management maintenance
          + * @testground/ipdx
          + 
          + # The github-mgmt stewards team is responsible for triaging/reviewing configuration change requests
          + # The ipdx team is added here temporarily to witness use patterns in github-mgmt
          + /github/testground.yml @testground/github-mgmt-stewards @testground/ipdx
        EOT
        id                  = "github-mgmt/CODEOWNERS"
        # (9 unchanged attributes hidden)
    }

  # github_team.this["github-mgmt stewards"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Users that are effectively org admins"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "github-mgmt stewards"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team.this["ipdx"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "ipdx"
      + node_id                   = (known after apply)
      + parent_team_id            = 6319375
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_membership.this["github-mgmt stewards:BigLep"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "BigLep"
    }

  # github_team_membership.this["github-mgmt stewards:galargh"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "galargh"
    }

  # github_team_membership.this["github-mgmt stewards:laurentsenta"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "laurentsenta"
    }

  # github_team_membership.this["ipdx:galargh"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "galargh"
    }

  # github_team_membership.this["ipdx:laurentsenta"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "laurentsenta"
    }

  # github_team_repository.this["github-mgmt stewards:github-mgmt"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "github-mgmt"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["ipdx:github-mgmt"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "github-mgmt"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["w3dt-stewards:github-mgmt"] will be destroyed
  # (because key ["w3dt-stewards:github-mgmt"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"d08c3fb659ed3a445cf6915c859973917d4d94038b4628b7c7af3315d5e58a4c\"" -> null
      - id         = "6319375:github-mgmt" -> null
      - permission = "maintain" -> null
      - repository = "github-mgmt" -> null
      - team_id    = "6319375" -> null
    }

Plan: 9 to add, 1 to change, 1 to destroy.

@galargh galargh requested a review from BigLep September 5, 2022 08:59
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once Laurent's comments are incorporated.

@galargh galargh marked this pull request as ready for review September 12, 2022 12:33
@galargh galargh merged commit e000f19 into master Sep 12, 2022
@galargh galargh deleted the github-mgmt-stewards branch September 12, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants