Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Python 2 support #12

Merged
merged 5 commits into from
Aug 20, 2024
Merged

remove Python 2 support #12

merged 5 commits into from
Aug 20, 2024

Conversation

a-detiste
Copy link
Contributor

jelmer
jelmer requested changes Aug 10, 2024
View reviewed changes
Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nit.

HACKING.rst Outdated Show resolved Hide resolved
@a-detiste
Copy link
Contributor Author

The 2.7 CI will never succeed

@jelmer
Copy link
Member

jelmer commented Aug 11, 2024

Looks like you also need to tox.ini

@jelmer
Copy link
Member

jelmer commented Aug 11, 2024

  • Hmm, still seems to be failing

@jelmer
Copy link
Member

jelmer commented Aug 20, 2024

Ping @a-detiste

@a-detiste
Copy link
Contributor Author

https://opendev.org/openstack/kolla/commit/fd49c3d6fe90b05d2181fe1f18481620b32506c3

@jelmer jelmer merged commit 5f8e403 into testing-cabal:master Aug 20, 2024
1 of 2 checks passed
@jelmer
Copy link
Member

jelmer commented Aug 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmer jelmer jelmer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-detiste @jelmer