-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note for throwSuggestions issue #1306 #1425
docs: add note for throwSuggestions issue #1306 #1425
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the friendly reminder @enmanuelduran .
This looks good, I just have a stylistic comment.
Co-authored-by: Tim Deschryver <[email protected]>
Change done @timdeschryver, It does look better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I went through the PR one last time and I think some sentences can be improved. Let me know what you think.
Co-authored-by: Tim Deschryver <[email protected]>
Co-authored-by: Tim Deschryver <[email protected]>
Co-authored-by: Tim Deschryver <[email protected]>
Agree with the suggestions, thanks for the improvements 👍 I have accepted the changes @timdeschryver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @enmanuelduran !
Glad to contribute @timdeschryver , do let me know if there is anything else I need to do so that you guys can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enmanuelduran :)
@all-contributors please add @enmanuelduran for docs :) |
I've put up a pull request to add @enmanuelduran! 🎉 |
As discussed with @MatanBobi and @timdeschryver this is the documentation change to account for issue found with the
throwSuggestions
option when enforced.For more context, this is discussed and related to issue #1306 in dom-testing-library.
Testing instructions