Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note for throwSuggestions issue #1306 #1425

Merged

Conversation

enmanuelduran
Copy link
Contributor

@enmanuelduran enmanuelduran commented Sep 14, 2024

As discussed with @MatanBobi and @timdeschryver this is the documentation change to account for issue found with the throwSuggestions option when enforced.

For more context, this is discussed and related to issue #1306 in dom-testing-library.

Testing instructions

Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit e7f0f3f
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/66f6f9dd3af5680008db1498
😎 Deploy Preview https://deploy-preview-1425--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the friendly reminder @enmanuelduran .
This looks good, I just have a stylistic comment.

docs/dom-testing-library/api-configuration.mdx Outdated Show resolved Hide resolved
@enmanuelduran
Copy link
Contributor Author

Thanks for the friendly reminder @enmanuelduran . This looks good, I just have a stylistic comment.

Change done @timdeschryver, It does look better.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I went through the PR one last time and I think some sentences can be improved. Let me know what you think.

docs/dom-testing-library/api-configuration.mdx Outdated Show resolved Hide resolved
docs/dom-testing-library/api-configuration.mdx Outdated Show resolved Hide resolved
docs/dom-testing-library/api-configuration.mdx Outdated Show resolved Hide resolved
@enmanuelduran
Copy link
Contributor Author

Sorry, I went through the PR one last time and I think some sentences can be improved. Let me know what you think.

Agree with the suggestions, thanks for the improvements 👍

I have accepted the changes @timdeschryver.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @enmanuelduran !

@enmanuelduran
Copy link
Contributor Author

Glad to contribute @timdeschryver , do let me know if there is anything else I need to do so that you guys can merge it.

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enmanuelduran :)

@MatanBobi MatanBobi merged commit 03b1695 into testing-library:main Sep 28, 2024
4 checks passed
@MatanBobi
Copy link
Member

@all-contributors please add @enmanuelduran for docs :)

Copy link
Contributor

@MatanBobi

I've put up a pull request to add @enmanuelduran! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants