update slf4j from 1.7.36 to 2.0.16 #3191
Conversation
WalkthroughThe changes involve updating the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)testng-core-api/testng-core-api-build.gradle.kts (2)
The upgrade from SLF4J 1.7.36 to 2.0.16 is a major version change that requires careful consideration. Let's verify the impact of this change: Please ensure the following migration requirements are addressed:
✅ Verification successfulSLF4J 2.x upgrade is safe to proceed The verification shows minimal SLF4J usage confined to a wrapper class
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for potential SLF4J migration issues and dependencies
# Search for direct SLF4J API usage that might need updates
echo "Checking for SLF4J API usage patterns that might need updates..."
rg -t java "org\.slf4j\.(Logger|LoggerFactory)" -A 3
# Look for other logging implementations that might conflict
echo "Checking for other logging implementations..."
fd -e gradle -e kts | xargs rg "(log4j|logback|commons-logging)"
Length of output: 1803
Since this is an Let's check for potential version conflicts: ✅ Verification successfulSLF4J 2.0.16 upgrade appears safe to proceed The verification shows:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for potential version conflicts in downstream projects
# Look for other modules that might declare different SLF4J versions
echo "Checking for SLF4J version declarations across all Gradle build files..."
fd -e gradle -e kts | xargs rg "org\.slf4j:slf4j-api:"
# Check for version constraints in platform/BOM definitions
echo "Checking for platform/BOM definitions that might constrain SLF4J version..."
fd -e gradle -e kts | xargs rg "platform\(['\"]org\.slf4j"
Length of output: 522 Script: #!/bin/bash
# Let's check for any direct or transitive dependencies on slf4j across the codebase
# This will help identify potential conflicts or compatibility issues
# Check for any slf4j imports in the codebase
echo "Checking for SLF4J imports across the codebase..."
rg "import.*org\.slf4j" -l
# Check for any logger declarations or usage
echo "Checking for logger declarations and usage..."
rg "LoggerFactory|Logger " -l
# Check if there are any other logging frameworks in use
echo "Checking for other logging frameworks..."
fd -e gradle -e kts | xargs rg "log4j|logback|commons-logging"
Length of output: 3816 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
slf4j 1.7.* is a very old version.
Many projects use the newer slf4j, but fallback to 1.7.36 because of TestNG transitive dependency.
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.
Summary by CodeRabbit