-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PoC github action runner macos-14 #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it may contain the openssl path
Problem: curl via homebrew comes with openssl. This is not what we want to use for this runner. |
.. although it seems not an option to include this in prod. RSsee #2765 Omitting redirecting stderr
For persisting the info: replacing 1x echo by /usr/bin/echo worked then for the macos runner. But that's ugly. |
AEAD-CHACHA20-POLY1305-SHA256 vs. TLS_CHACHA20_POLY1305_SHA256
as suggested, see #2765 (comment)
... wrt to the now even better unit testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a PoC which tries incrementally to get the github actions working for the provided macos-14 runner . Reason: we missed a few incompatibilities in the past, see #2760, #2707, #2705 etc --mostly because of LibresSSL and bash version 3.
For now it uses a modified Ubuntu runner from the main branch. Goal is to use all the checks for MacOS , except the ones which won't work (MacOS doesn't have
timeout
e.g.) .What is your pull request about?
If it's a code change please check the boxes which are applicable
help()