Add readers and writers instances for cats-collections #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have problems with some collections, such as Range: how does look like Range(1,5) in Json? I have two option: [1,2,3,4,5] and [1, 5]. Which option is correct? How to read Range from Json? It might not be worth implementing instances for this and anyone can do it themselves? |
dos65
reviewed
May 3, 2024
build.sbt
Outdated
| @@ -9,7 +9,7 @@ lazy val scala3 = "3.3.0" | |||
| ThisBuild / scalaVersion := scala3 | |||
|
|
|||
| lazy val commonSettings = Seq( | |||
| version := "0.28.4", | |||
There was a problem hiding this comment.
Could you rebase commit on a master branch?
There is no more need to update version by hand
Roman-Statsura
force-pushed
the
cats-collections
branch
from
b4092af
to
5a4c804
Compare
|
@Roman-Statsura Sorry for delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add readers and writers instances for cats-collections