Remove customSettings key in unathenticated responses

tethysplatform · Jan 5, 2024 · 4707fac · 4707fac
1 parent 8ec874f
commit 4707fac
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/tethys_portal/views/api.py b/tethys_portal/views/api.py
@@ -44,16 +44,6 @@ def get_app(request, app):
     except TethysApp.DoesNotExist:
         return JsonResponse({"error": f'Could not find app "{app}".'})
 
-    custom_settings = {}
-    if request.user.is_authenticated:
-        custom_settings = {
-            s.name: {
-                "type": s.type,
-                "value": s.get_value(), 
-            } 
-            for s in app.custom_settings
-        }
-
     metadata = {
         "title": app.name,
         "description": app.description,
@@ -65,6 +55,15 @@ def get_app(request, app):
         "exitUrl": reverse("app_library"),
         "rootUrl": reverse(app.index_url),
         "settingsUrl": f'{reverse("admin:index")}tethys_apps/tethysapp/{ app.id }/change/',
-        "customSettings": custom_settings,
     }
+
+    if request.user.is_authenticated:
+        metadata["customSettings"] = {
+            s.name: {
+                "type": s.type,
+                "value": s.get_value(), 
+            } 
+            for s in app.custom_settings
+        }
+
     return JsonResponse(metadata)