Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue with Typo in MapLayout Basemaps #1017

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

gagelarsen
Copy link
Contributor

This PR is to resolve issue #998.

The addLayer call for adding a map layer was outside of the check for supported basemap type. I just moved the call into the correct scope.

@gagelarsen gagelarsen changed the title fix issue where specifying a basemap that didn't exist would blow all… Fix Issue with Typo in MapLayout Basemaps Mar 13, 2024
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 7355baa on map_layer_typo_bug
into d65dd68 on main.

@shawncrawley shawncrawley self-requested a review March 14, 2024 20:53
Copy link
Contributor

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@gagelarsen gagelarsen merged commit 56ea3da into main Mar 19, 2024
10 checks passed
@gagelarsen gagelarsen deleted the map_layer_typo_bug branch May 28, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants