-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(base-cluster/dependencies): update helm release common to v2.11.1 - autoclosed #581
Conversation
31ec011
to
d9aa116
Compare
In 2.11.1 common chart a new label app.kubernetes.io/version with the value .Chart.AppVersion was added. We do not set the value appVersion in the base-cluster chart which is totaly correct but for now we have a new label app.kubernetes.io/version: "" on every resource which uses the common.labels from the chart. |
Mh, then we should either add a version to our chart, which would semantically be useless, or remove that version label from everything which would be a lot of work 😅 What do you think? @tasches @marvinWolff |
9876ca1
to
361ab0e
Compare
d52ab65
to
c01f3e9
Compare
178108f
to
d973107
Compare
6e42a29
to
9407488
Compare
IMOH we should just add a version to our chart and avoid the extra work of removing the label from every resource. It is useless yes but it won't hurt either ;) |
why did the rennovate bot create a new PR instead of updating this one 🤔 ? |
Different minor version it looks like |
So just a never changing |
82d7ca1
to
69642ca
Compare
69642ca
to
dc3c4d7
Compare
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
Pull request was closed
This PR contains the following updates:
2.11.0
->2.11.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.