Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(t8s-cluster/management-cluster): make field availabilityZone optional #592

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Sep 27, 2023

This allows OpenStack to distribute it better

And more often than not the user doesn't care about the availabilityZone anyways

Depends on https://gitlab.teuto.net/4teuto/ops/k8s/t8s-engine/-/merge_requests/659

…ional

This allows [OpenStack to distribute it better](https://gitlab.teuto.net/4teuto/ops/k8s/t8s-engine/-/issues/9#note_122490)
And normally the user doesn't care about the availabilityZone
@cwrau cwrau force-pushed the feat/t8s-cluster-remove-required-zone branch from 6373f28 to 2840443 Compare September 27, 2023 13:07
@teutonet-bot
Copy link
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/t8s-cluster/ci/artifacthub-values.yaml has no changes

charts/t8s-cluster/ci/cidrs-values.yaml

charts/t8s-cluster/ci/injectedCertificateAuthorities-values.yaml

charts/t8s-cluster/ci/securityGroups-values.yaml

charts/t8s-cluster/ci/calico-values.yaml

charts/t8s-cluster/ci/bastion-values.yaml

charts/t8s-cluster/values.yaml

charts/t8s-cluster/ci/gpu-flavor-values.yaml

Copy link
Collaborator

@tasches tasches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants