fix(backup): make it possible to create backups for velero #595
Conversation
marvinWolff
changed the title
marvinWolff
changed the title
| @@ -91,6 +91,27 @@ spec: | |||
| {{- end }} | |||
| volumeSnapshotLocation: [] | |||
| metrics: | |||
| prometheusRule: | |||
| additionalLabels: {{- .Values.monitoring.labels | toYaml | nindent 10 }} | |||
| enabled: true | |||
There was a problem hiding this comment.
This should also only be enabled if prometheus is activated, just like with the ServiceMonitor , so I would just not set this, as this is also autodetected
| @@ -1046,6 +1046,11 @@ | |||
| "enabled": { | |||
| "type": "boolean" | |||
| }, | |||
| "alerting":{ | |||
| "enabled":{ | |||
| "type": "boolean" | |||
There was a problem hiding this comment.
You added this boolean but you don't use it?
I don't get why this boolean exist in any case?
| - alert: VeleroBackupPartialFailures | ||
| annotations: | ||
| message: {{ `Velero backup {{ $labels.schedule }} has {{ $value | humanizePercentage }} partialy failed backups.` }} | ||
| expr: velero_backup_partial_failure_total{schedule!=""} / velero_backup_attempt_total{schedule!=""} > 0.25 |
There was a problem hiding this comment.
Isn't there a nicer way to really detect backup failure?
These metrics only point to problems, as with the current one we could have 3 failed attempts and 1 successful one (which is good in my eyes) which would still trigger the alert
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
Ref.: #487