Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(teuto-portal-k8s-worker): initial implementation #622

Merged
merged 8 commits into from
Nov 28, 2023
Merged

feat(teuto-portal-k8s-worker): initial implementation #622

merged 8 commits into from
Nov 28, 2023

Conversation

tasches
Copy link
Collaborator

@tasches tasches commented Nov 10, 2023

add helmchart for the teutoportal-worker

@tasches tasches self-assigned this Nov 10, 2023
@tasches tasches requested a review from a team as a code owner November 10, 2023 14:43
@tasches tasches requested review from brolga, cwrau and marvinWolff and removed request for brolga November 10, 2023 14:43
cwrau
cwrau requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@cwrau cwrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick, it's called the teuto-portal 😉

Please adjust accordingly

And you should do a rebase

@tasches tasches force-pushed the feat/add-teutoportal-worker branch from c3921f4 to 90170f7 Compare November 15, 2023 15:07
@tasches tasches changed the title feat(teutoportal-worker): initial implementation feat(teuto-portal): initial implementation Nov 15, 2023
@tasches tasches force-pushed the feat/add-teutoportal-worker branch 3 times, most recently from 856ce68 to b367d25 Compare November 15, 2023 16:15
@tasches
feat(teutoportal-worker): initial implementation
74b8ca4 
fix: rename chart

fix: remove duplicated chart

fix: add new line

fix: remove new line at eof

fix: maintainer names
@tasches tasches force-pushed the feat/add-teutoportal-worker branch from b367d25 to 74b8ca4 Compare November 15, 2023 16:26
@tasches
Copy link
Collaborator Author

tasches commented Nov 15, 2023

Just one nitpick, it's called the teuto-portal 😉

Please adjust accordingly

And you should do a rebase

done.

@tasches tasches requested a review from cwrau November 15, 2023 16:29
@cwrau
Copy link
Member

cwrau commented Nov 17, 2023

Just one nitpick, it's called the teuto-portal 😉

Please adjust accordingly

And you should do a rebase

done.

I'm sorry, I was not clear, teutoportal should be teuto-portal. In total it's teuto-portal-k8s-worker 😅

cwrau
cwrau requested changes Nov 17, 2023
View reviewed changes
charts/teutoportal-worker/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/teuto-portal/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/teuto-portal/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/teuto-portal/templates/secret.yaml Outdated Show resolved Hide resolved
charts/teuto-portal/values.schema.json Outdated Show resolved Hide resolved
charts/teuto-portal/values.yaml Outdated Show resolved Hide resolved
charts/teuto-portal/values.yaml Outdated Show resolved Hide resolved
@tasches tasches changed the title feat(teuto-portal): initial implementation feat(teuto-portal-k8s-worker): initial implementation Nov 20, 2023
@tasches tasches force-pushed the feat/add-teutoportal-worker branch from 1031439 to 7c51432 Compare November 27, 2023 13:35
@tasches tasches requested a review from cwrau November 27, 2023 13:46
@tasches tasches force-pushed the feat/add-teutoportal-worker branch from 7a10f5f to 1b9abee Compare November 27, 2023 13:51
@teutonet-bot
Copy link
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/teuto-portal-k8s-worker/values.yaml has no changes

charts/teuto-portal-k8s-worker/ci/worker-values.yaml

@tasches tasches merged commit c8c8128 into main Nov 28, 2023
11 checks passed
@tasches tasches deleted the feat/add-teutoportal-worker branch November 28, 2023 11:05
@teutonet-bot teutonet-bot mentioned this pull request Jan 18, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Feb 7, 2024
Merged
This was referenced Apr 26, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwrau cwrau cwrau approved these changes

@marvinWolff marvinWolff Awaiting requested review from marvinWolff marvinWolff is a code owner

Assignees

@tasches tasches

Labels
teuto-portal teuto-portal-k8s-worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tasches @cwrau @teutonet-bot