Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(Webpack): upgrade webpack to v5 #666

Closed
wants to merge 1 commit into from

Conversation

carlobernardini
Copy link
Contributor

@carlobernardini carlobernardini commented Dec 22, 2021

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Use imperative, present tense in your commit description ("change", not "changed" or "changes") without uppercases or period (.) at the end.

Checklist

  • The implementation has been manually tested and complies with Textkernel browser support guidelines
  • The implementation complies with accessibility standards.
  • The component has a displayName defined.
  • The component comes with a detailed PropTypes (and defaultProps) definition.
  • Component PropTypes are sufficiently described / documented.
  • There is a story in Storybook.

@carlobernardini carlobernardini changed the title WIP: deps(Webpack): upgrade webpack to v5 WIP: build(Webpack): upgrade webpack to v5 Dec 23, 2021
@carlobernardini carlobernardini changed the title WIP: build(Webpack): upgrade webpack to v5 build(Webpack): upgrade webpack to v5 Dec 23, 2021
@carlobernardini
Copy link
Contributor Author

@antipin appreciate it if you could take a look this week.


optimization: {
moduleIds: 'named',
minimize: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep the base (and thus dev) configs un-minimised, and move it to webpack.prod.conf.js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense indeed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I just found out that Storybook doesn't run on Webpack 5 so this is back to square one I'm afraid :(

@antipin antipin self-assigned this Aug 11, 2022
@antipin antipin added the blocked Do not merge label Aug 17, 2022
@antipin
Copy link
Contributor

antipin commented Aug 17, 2022

Blocked on #801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants