-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(Webpack): upgrade webpack to v5 #666
Conversation
9548c52
to
d1ccae2
Compare
@antipin appreciate it if you could take a look this week. |
|
||
optimization: { | ||
moduleIds: 'named', | ||
minimize: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we keep the base (and thus dev) configs un-minimised, and move it to webpack.prod.conf.js
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I just found out that Storybook doesn't run on Webpack 5 so this is back to square one I'm afraid :(
d1ccae2
to
fa4c984
Compare
Blocked on #801 |
fa4c984
to
1556747
Compare
1556747
to
ad1ed92
Compare
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Use imperative, present tense in your commit description ("change", not "changed" or "changes") without uppercases or period (.) at the end.
Checklist