Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial fix to consider 'only' optimization for relay #31

Closed
wants to merge 2 commits into from

Conversation

bellini666
Copy link
Contributor

This is an initial step to solve #24

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #31 into master will decrease coverage by 0.25%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   93.22%   92.97%   -0.26%     
==========================================
  Files           6        6              
  Lines         310      313       +3     
==========================================
+ Hits          289      291       +2     
- Misses         21       22       +1
Impacted Files Coverage Δ
graphene_django_optimizer/query.py 91.4% <75%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48db2b2...3cd05a5. Read the comment docs.

@NyanKiyoshi
Copy link
Collaborator

Hi! Thank you for the PR! Could you add the proper test cases for it? Thanks!

@tpict tpict mentioned this pull request Mar 13, 2020
@gghildyal
Copy link

gghildyal commented Jun 15, 2020

@NyanKiyoshi @bellini666 There is indeed already a tests that attempts to test this very scenario.

See test_relay.py::test_should_optimize_query_by_only_requesting_id_field. Although the aim of the test is to test the very same scenario, it fails to reproduce this issue (and passes with the buggy code) because create_resolve_info() function doesn't set up the GlobalID field like it should be (i.e inside of a partial function).

@bellini666
Copy link
Contributor Author

I'm closing this PR since #44 supersedes this.

@bellini666 bellini666 closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants