Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to setup.cfg #1162

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

deronnax
Copy link

@deronnax deronnax commented Jan 31, 2024

An initiative of my own. Setup.py is a thing of the past and will soon be gone, and declarative config is superior and recommended by setuptools. I am polishing it on my fork and will remove the "draft" label when done.

@deronnax deronnax marked this pull request as draft January 31, 2024 23:06
@deronnax deronnax force-pushed the migrate-to-setup-cfg branch from 6117874 to 07b7f76 Compare January 31, 2024 23:12
@deronnax deronnax force-pushed the migrate-to-setup-cfg branch from 07b7f76 to 5f5c0bf Compare February 1, 2024 09:05
@johnthagen
Copy link
Contributor

johnthagen commented May 1, 2024

Porting to pyproject.toml is likely the preferred thing to do here if modernizing in the goal

@deronnax
Copy link
Author

deronnax commented May 2, 2024

I'll make you that, it's just few minutes of more work. Stay tuned.
update: @johnthagen are you a core maintainer? Do you have the capability to merge this supplemental work you are asking for?

@johnthagen
Copy link
Contributor

johnthagen commented May 2, 2024

@deronnax No, not a core maintainer, just someone who has contributed to drf-spectacular in the past and noticed this MR and have experience with modern packaging tools.

@tfranzel
Copy link
Owner

tfranzel commented May 2, 2024

Hi y'all,

the reason I have not approached this is because python packaging is fickle. Anybody that has ever messed with include_package_data and MANIFEST.in probably knows this all to well. I know this approach is outdated, but it works. Maybe the new tools work just fine, but I almost got PTSD from packaging before. So we must check the difference of both the the source build as well as the wheel (including structure and all contained files)!

I think if porting, we should go directly to pyproject.toml as John said, instead of updating from the outdated solution to the semi-outdated solution.

@deronnax
Copy link
Author

@tfranzel I'll do you the move to pyproject. Assign the issue to me please.

@tfranzel
Copy link
Owner

@deronnax yes please give it a shot. You can either do a new PR or change this one. Since this is already your PR, there is no need to assign you to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants