Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate worker for logging & excluded THUB_TOKEN_IS_VALID from env #801

Merged
merged 21 commits into from
Jul 2, 2019

Conversation

aluchianic
Copy link
Contributor

@aluchianic aluchianic commented Jul 2, 2019

Description

Fixes #784, #794

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a change to the documentation

How Has This Been Tested?

  • terrahub run (with/without token, with/without aws.creds)
  • terrahub destroy (with/without token, with/without aws.creds)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked that my changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@eistrati eistrati merged commit 1d316f4 into dev Jul 2, 2019
@eistrati eistrati deleted the feature/separate_worker branch July 2, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants