Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3+ support and MIT license file #3

Merged
merged 5 commits into from
Oct 8, 2021

Conversation

mrakitin
Copy link
Collaborator

@mrakitin mrakitin commented Oct 6, 2021

This PR adds the Python 3+ support (based on master...ronpandolfi:master changes) and adds a missing LICENSE file with the MIT license text.

xref #2 (comment).

@mikapfl
Copy link

mikapfl commented Oct 7, 2021

I tested building, installing, and importing pygix under python 3 with these patches and it works nicely. Unfortunately, I don't have the time to try out a full workflow (calibration, transformation of image, etc.).

Note that I'm no developer of pygix, this is just a drive-by comment to confirm that it works and thank you for your patches. (-:

@mrakitin
Copy link
Collaborator Author

mrakitin commented Oct 7, 2021

Hi @mikapfl, thanks for giving it a try! I actually created a recipe for conda and submitted it to conda-forge (via conda-forge/staged-recipes#16399), and now we have this feedstock to build the package - https://github.com/conda-forge/pygix-feedstock. Please feel free to add yourself as a maintainer if you wish.

The advantage of conda is that it can perform tests for the packaged code, so I added a number of imports that actually captured the missing pyyaml dependency. I'll add it here too.

@tgdane tgdane merged commit 044e468 into tgdane:master Oct 8, 2021
@mrakitin mrakitin deleted the add-license branch October 8, 2021 15:29
@mrakitin
Copy link
Collaborator Author

mrakitin commented Oct 8, 2021

Thank you, @tgdane!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants