Skip to content

Commit

Permalink
Bugfix from linting changes. More doc changes and additional notes.
Browse files Browse the repository at this point in the history
  • Loading branch information
tgorgdotcom committed Sep 16, 2020
1 parent 8c48346 commit 1469a67
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 0.6.0 (unreleased)
- Switch to Python 3 (Thanks @ratherDashing!)
- Added all the market codes/FCC names so we don't have to add them when Locast enables them (Thanks @deathbybandaid!)
- Update FCC Facility list

## 0.5.3
- Scripts are now fully linted (Thanks @deathbybandaid!)
Expand Down
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ for rules E303, E501, W504, W605. I will be pretty lenient in taking pull reque
so don't worry if you're not already familiar with linting. A good primer
on [linting in Python is here](https://realpython.com/python-code-quality/)

## Versioning Scheme
We use the Semantic versioning scheme, with the following naming conventions for non-stable
releases:
- The 0.x series is beta
- Releases marked `-alpha` or `-beta` at the end of the version number. An additional number,
starting from 1, is added after this postfix to separate different version numbers.
Example: `2.0.0-beta3`

## Road Map and New feature discussion
Plans for close-at-hand future releases are typically listed in CHANGELOG. New features
discussions can be made in GitHub as a new issue. I can also look into setting up other
Expand Down
2 changes: 1 addition & 1 deletion LocastService.py
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ def get_station_stream_uri(self, station_id):

if len(videoUrlM3u.playlists) > 0:
for videoStream in videoUrlM3u.playlists:
if bestStream is not None:
if bestStream is None:
bestStream = videoStream

elif ((videoStream.stream_info.resolution[0] > bestStream.stream_info.resolution[0]) and
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Time is limited due to other major factors (work, wife/kids), so please understa

As always, pull requests are welcome.

### Beta Software
Currently this is BETA, so regressions may be common in updated versions. I hope for us to be "officially" stable at v1.0


## Set up options:
Expand Down
12 changes: 12 additions & 0 deletions Test Senarios.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Environments to test in
- Check for various config settings and if they work
- Test inside Docker container
- Test in Command Line/Terminal

What to look for:
- Can I ping server?
- Can I get device.xml
- Can I get list of channels?
- Test for m3u8 stream with multiple resolutions
- Test for m3u8 stream with one resolution
- Test a stream for 60mins
Binary file removed m3u8/__init__.pyc
Binary file not shown.
Binary file removed m3u8/iso8601/__init__.pyc
Binary file not shown.
Binary file removed m3u8/iso8601/iso8601.pyc
Binary file not shown.
Binary file removed m3u8/mixins.pyc
Binary file not shown.
Binary file removed m3u8/model.pyc
Binary file not shown.
Binary file removed m3u8/parser.pyc
Binary file not shown.

0 comments on commit 1469a67

Please sign in to comment.