Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents early launch of pods/shuttles as soon as evac is triggered #16647

Closed
wants to merge 1 commit into from

Conversation

Notamaniac
Copy link
Contributor

@Notamaniac Notamaniac commented Oct 7, 2024

About The Pull Request

The evac timer now must elapse before the pod can be early launched

Why It's Good For The Game

No more guaranteed xeno minor
Fixes (possible) unintended oversight

Technicially this means now mashing the button will only launch the pod a couple seconds sooner, since all pods begin auto launching as soon as the evac timer finished, but oh well.

Changelog

🆑
fix: Stops pods/shuttles from being launched early before evac timer elapses
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label Oct 7, 2024
@Lumipharon
Copy link
Contributor

definitely an oversight that marines can insta evac for xeno minor, but this kinda makes the button just redundant entirely

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 21, 2024
@github-actions github-actions bot closed this Oct 25, 2024
@ivanmixo ivanmixo reopened this Oct 25, 2024
@ivanmixo ivanmixo removed the Stale Pull request is awaiting delayed author response and may be closed. label Oct 25, 2024
Copy link
Contributor

@ivanmixo ivanmixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this button is useless since the pods auto launch could you just delete it? Have the UI just tell you how much longer to evac and remove the button or something.

@Notamaniac Notamaniac closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants