Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having 100% Fire Armor Gives You Actual Fire Immunity #16658

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

Runian
Copy link
Contributor

@Runian Runian commented Oct 11, 2024

About The Pull Request

Fire and the type of fire that Pyrogen uses now considers soft armor (instead of hard armor) and also prevents your body temperature from increasing. This means:

  • No more endless screaming for walking through fire.
  • No more taking damage for walking through fire.
  • No more getting too hot for walking through fire.
  • Because of all of the above, your very fragile splints no longer instantly break for walking through fire.

Why It's Good For The Game

I hope that H-Armor + Surt not getting actual fire immunity is a bug and not a feature.

Changelog

🆑
fix: All types of fire no longer damages or heats you up if you have 100% fire soft/hard armor.
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label Oct 11, 2024
@FosterGrime-Heymynameslouie
Copy link
Contributor

FosterGrime-Heymynameslouie commented Oct 11, 2024

I believe the surt with heavy armor is intended in this pr

heavy slowdown but fire immune with surt

#16029

really cool pr spedmghr

@Mannybrado
Copy link
Contributor

the surt buff all surtheads were waiting for

Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just sap the hard armour checks for soft armour. The hardarmour checks are a legacy from how surt used to work

@Lumipharon Lumipharon merged commit d4e6604 into tgstation:master Oct 14, 2024
39 checks passed
github-actions bot added a commit that referenced this pull request Oct 14, 2024
@Runian Runian deleted the surt-and-fire branch October 15, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants