Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chestbursting can now happen in EORD/Deathmatch #16692

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

Runian
Copy link
Contributor

@Runian Runian commented Oct 21, 2024

About The Pull Request

Chestbursting can happen in the Deathmatch Area (as in the area where you go to when you EORD Respawn) without admin intervention.

Why It's Good For The Game

If people wanna play xenos during EORD, they should be allowed to. And the people who don't wanna play xeno should be able to shoot said xenos for existing. Only really happens if EORD lasts ages and not when the round restarts in a couple minutes.

Changelog

🆑
add: You can now chestburst while in EORD/Deathmatch Area without requiring admin intervention.
/:cl:

@tgstation-server tgstation-server added the Feature New interesting mechanics with new interesting bugs label Oct 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 29, 2024
@TiviPlus
Copy link
Member

Tbh should just make it so you can respawn as xeno in eord but this is whateve to guess

Comment on lines 135 to 137
var/area/mob_area = get_area(affected_mob)
if(is_centcom_level(affected_mob.z) && mob_area.type != /area/deathmatch && !admin)
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use !istype

@Runian Runian requested a review from TiviPlus October 29, 2024 17:16
@TiviPlus TiviPlus merged commit 959a310 into tgstation:master Oct 31, 2024
39 of 40 checks passed
github-actions bot added a commit that referenced this pull request Oct 31, 2024
@Runian Runian deleted the eord-larva-xenos branch October 31, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Stale Pull request is awaiting delayed author response and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants