Skip to content

Commit

Permalink
[TH2-5165] revert logic to skip register load for empty day page inte…
Browse files Browse the repository at this point in the history
…rval
  • Loading branch information
Nikita-Smirnov-Exactpro committed Mar 5, 2024
1 parent 7ecc0ed commit 0d29959
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cradle-core/src/main/java/com/exactpro/cradle/BookInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@ private IPageInterval getPageInterval(Instant timestamp) {
if (loaded.isEmpty()) {
return null;
}
// We shouldn't register `load` when day page interval (interval in the next) is empty because don't register `request` for empty interval.
// `EmptyPageInterval` handles `requests` for empty interval and doesn't register `request`
// `loads` and `requests` are required for calculating hit / miss rate
METRICS.incLoads(id, cacheName, loaded.size());
return create(id, start, cacheName, loaded);
}

Expand Down

0 comments on commit 0d29959

Please sign in to comment.