Th2 3673 common need to change the filter #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...t/kotlin/com/exactpro/th2/common/schema/filter/strategy/impl/TestAnyMessageFilterStrategy.kt
Outdated
Show resolved
Hide resolved
Comment on lines
391
to
394
| arguments(simpleMessageBuilder("test", Direction.FIRST, "test-alias"), true), | ||
| arguments(simpleMessageBuilder("test", Direction.SECOND, "test-alias"), true), | ||
| arguments(simpleMessageBuilder("test", Direction.FIRST, "test-wrong"), true), | ||
| arguments(simpleMessageBuilder("test", Direction.SECOND, "test-alias-wrong"), false), |
There was a problem hiding this comment.
I mean this case, here we can see:
- simpleMessageBuilder - the base structure of the target message
- "test", SECOND, "test-alias-wrong" - arguments
Could you please write others methods in a similar style
| import org.mockito.kotlin.mock | ||
| import org.mockito.kotlin.never | ||
| import org.mockito.kotlin.verify | ||
| import org.mockito.kotlin.* |
There was a problem hiding this comment.
Please avoid multiple imports. You can configure idea for that
.../exactpro/th2/common/schema/message/impl/rabbitmq/group/TestRabbitMessageGroupBatchRouter.kt
Outdated
Show resolved
Hide resolved
Nikita-Smirnov-Exactpro
requested changes
May 19, 2022
src/main/java/com/exactpro/th2/common/schema/filter/strategy/impl/AbstractFilterStrategy.java
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/common/schema/filter/strategy/impl/AnyMessageFilterStrategy.kt
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/common/schema/filter/strategy/impl/AnyMessageFilterStrategy.kt
Show resolved
Hide resolved
Nikita-Smirnov-Exactpro
previously approved these changes
May 23, 2022
Nikita-Smirnov-Exactpro
previously approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.