Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH2-1988-2 #321

Merged
merged 13 commits into from
Jul 12, 2024
Merged

TH2-1988-2 #321

merged 13 commits into from
Jul 12, 2024

Conversation

lumber1000
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jul 8, 2024

Test Results

 31 files   31 suites   5s ⏱️
412 tests 412 ✅ 0 💤 0 ❌
477 runs  477 ✅ 0 💤 0 ❌

Results for commit f5f9207.

♻️ This comment has been updated with latest results.

Copy link
Member

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please investigate the vulnerability and try to fix it by the lib update
commons-compress-1.24.0.jar (pkg:maven/org.apache.commons/[email protected], cpe:2.3:a:apache:commons_compress:1.24.0:::::::*) : CVE-2024-25710, CVE-2024-26308

@lumber1000 lumber1000 marked this pull request as ready for review July 12, 2024 10:14
@lumber1000 lumber1000 merged commit 0c70cd5 into master Jul 12, 2024
12 checks passed
@lumber1000 lumber1000 deleted the TH2-1988-2 branch July 12, 2024 11:54
@@ -172,6 +172,18 @@ dependencies {
testFixturesImplementation "org.junit.jupiter:junit-jupiter:$junitVersion"
}

// substitute commons-compress:1.24.0 from testcontainers:1.19.8 to version 1.26.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note: this comes from test dependency. why do we need this substitution for all configurations? They are not present in the production distribution.
Also, we must remember now to remove this block once the testcontainers dependency is updated and no longer contains this vulnerability. The best way would be to exclude the test configurations from scanning - we don't get alerts on dependencies that we don't care about and we don't need to do things like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants