[TH2-3689] Mangler > Add basic support for repeating groups #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cordwelt
force-pushed
the
TH2-3689
branch
2 times, most recently
from
513b7d6 to
aa71f63
Compare
Nikita-Smirnov-Exactpro
requested changes
Feb 22, 2023
| matching: C | ||
| ``` | ||
|
|
||
| Where `group` is a name of a predefined group and `contains` is a list of field selectors |
There was a problem hiding this comment.
Could you please explain what will be happened when a message contains more than one group matched by filter
| NoPartyIDs: | ||
| counter: 453 | ||
| delimiter: 448 | ||
| tags: [ 447, 452 ] | ||
| rules: |
There was a problem hiding this comment.
Could you please add example where we update repeating group field
| var group = fields.findGroup(counter, delimiter, tags) | ||
|
|
||
| while (group != null) { | ||
| if (selectors.all(group::contains)) return group |
There was a problem hiding this comment.
Could you please add information into README about behavior of this function in case where several groups contains the same values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.